added PassiveADPAgent, PassiveTDAgent, and QLearningAgent in rl.py#1
Open
yeesian wants to merge 19 commits intodarius:masterfrom
Open
added PassiveADPAgent, PassiveTDAgent, and QLearningAgent in rl.py#1yeesian wants to merge 19 commits intodarius:masterfrom
yeesian wants to merge 19 commits intodarius:masterfrom
Conversation
…ixing Issue 31 (quadratic search times). Note that __getitem__() and __delitem__() are still linear time, but could easily be improved also if necessary.
original code from Steve Klebanoff at https://github.com/steveklebanoff/AIMA-Python-Reinforcement-Learning/blob/master/passive_adp.py
to look more like the pseudo-code, and removed the logging
since it's a model of the mdp that is internal to the passive adp agent.
and merged it into rl.py
where alpha (rather than self.alpha) was called
added an attribute: reached_states to track new states.
Owner
|
Sorry I've left this fallow so long! I'll review the new code within a week. |
and always convert them to LF on checkout
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PassiveADPAgent based loosely on the code by Steve Klebanoff at https://github.com/steveklebanoff/AIMA-Python-Reinforcement-Learning/blob/master/passive_adp.py